Add support for service fees #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new transaction type "service_fee" Each outgoing payment is charged a service fee of x/1000. The service fee entries is added with the routing fee reserve entry. For failed payments the service fee is reversed.
ignore NoRows errors
payment amounts up to NO_SERVICE_FEE_UP_TO_AMOUNT don't get a service fee charged
reneaaron
reviewed
Dec 29, 2023
|
transaction entries are associated with the invoice and have a type (outgoing, service_fee, fee, etc.)this is associating the related tx entries.
|
we already do exactly that when in the normal PayInvoice flow. Normally the RHash is already set here, but I guess it does not hurt to have it consistent everywhere.
…harged It feels a bit indirect to check if we have set a FeeReserve. We save the routing fee on the invoice thus we should be able to use that information
bumi
commented
Dec 30, 2023
| @@ -359,22 +385,35 @@ func (svc *LndhubService) RevertFeeReserve(ctx context.Context, entry *models.Tr | |||
| return nil | |||
| } | |||
|
|
|||
| func (svc *LndhubService) AddFeeEntry(ctx context.Context, entry *models.TransactionEntry, invoice *models.Invoice, tx bun.Tx) (err error) { | |||
| if entry.FeeReserve != nil { | |||
There was a problem hiding this comment.
@kiwiidb why did we check for entry.FeeReserve here? can't we check for invoice.Fee (new name invoice.RoutingFee) here?
If the invoice has a not zero routing fee we have to add a fee transaction entry.
There was a problem hiding this comment.
I guess it can also work but the way how it used to be it's more explicit in avoiding the nil pointer exception.
bumi
commented
Jan 2, 2024
we want those to be 0 by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new transaction type "service_fee".
Each outgoing payment is charged a service fee of x/1000. The service fee entries is added with the routing fee reserve entry. For failed payments the service fee is reversed.
A threshold up to which transactions are free can be configured (
NO_SERVICE_FEE_UP_TO_AMOUNT)