feat: add created_at to create invoice response #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 59.12% 59.21% +0.09%
==========================================
Files 51 51
Lines 3481 3482 +1
==========================================
+ Hits 2058 2062 +4
+ Misses 1202 1200 -2
+ Partials 221 220 -1
|
kiwiidb
approved these changes
Sep 5, 2023
bumi
reviewed
Sep 6, 2023
| @@ -134,6 +134,7 @@ type AddInvoiceResponseBody struct { | |||
| PaymentHash string `json:"payment_hash"` | |||
| PaymentRequest string `json:"payment_request"` | |||
| ExpiresAt time.Time `json:"expires_at"` | |||
| CreatedAt time.Time `json:"created_at"` | |||
There was a problem hiding this comment.
can we return this as timestamp? otherwise we have to deal with timezones?
bumi
reviewed
Sep 6, 2023
| @@ -174,6 +175,7 @@ func (controller *InvoiceController) AddInvoice(c echo.Context) error { | |||
| PaymentHash: invoice.RHash, | |||
| PaymentRequest: invoice.PaymentRequest, | |||
| ExpiresAt: invoice.ExpiresAt.Time, | |||
| CreatedAt: invoice.CreatedAt, | |||
There was a problem hiding this comment.
why is it CreatedAt here but ExpiresAt.Time above?
There was a problem hiding this comment.
expiresAt is nullable, you can create an invoice that does not expire
kiwiidb
added a commit
that referenced
this pull request
Sep 7, 2023
…voice-response feat: add created_at to create invoice response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
untested