Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move dd tracer start back to main #400

Merged
merged 1 commit into from
Jul 20, 2023
Merged

move dd tracer start back to main #400

merged 1 commit into from
Jul 20, 2023

Conversation

kiwiidb
Copy link
Contributor

@kiwiidb kiwiidb commented Jul 20, 2023

In my refactoring enthusiasm I've introduced a bug that stopped APM for LNDhub.go 😅 .
the defer tracer.Stop() causes the tracer to stop immediately if not called from main.go.

@kiwiidb kiwiidb requested a review from bumi July 20, 2023 15:18
@kiwiidb kiwiidb merged commit ffa831a into main Jul 20, 2023
3 checks passed
@kiwiidb kiwiidb deleted the fix/dd-apm branch July 20, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant