Simplify dev container and fix pre-commit repo #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Dev tools
What is the current behavior? (You can also link to an open issue here)
Coming back to this (on a fresh machine), the original dev container was no longer working for me and the pre-commit was failing to initialize on my end (both in dev containers and on my local machine). After installing the pre-commit and installing the Go dev tools, I was seeing a "Connection refused" error for the
pre-commit-golang
repo whenever I created a commit.I'm curious if others are able to reproduce these issues?
What is the new behavior (if this is a feature change)?
This PR replaces the old dev container with a new and simpler one, leveraging some of the recent updates from VS Code Dev Containers (i.e. dev container "features").
This PR also resolves the pre-commit issues by replacing
git://github.com/caitlinelfring/pre-commit-golang
withhttps://github.com/caitlinelfring/pre-commit-golang
. This got pre-commit working for me—I'm very curious if this still works for others!Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
If contributors are still using the current dev container, they should be able to just "Rebuild Container" in VS Code to start using the updated one.
If the pre-commit change also looks good and is accepted, contributors may need to run another
pre-commit install
to reflect the change.Other information:
Please let me know your thoughts!