Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dev container and fix pre-commit repo #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeremydelacruz
Copy link
Contributor

@jeremydelacruz jeremydelacruz commented Dec 29, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) see docs/README.md

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Dev tools

What is the current behavior? (You can also link to an open issue here)

Coming back to this (on a fresh machine), the original dev container was no longer working for me and the pre-commit was failing to initialize on my end (both in dev containers and on my local machine). After installing the pre-commit and installing the Go dev tools, I was seeing a "Connection refused" error for the pre-commit-golang repo whenever I created a commit.

I'm curious if others are able to reproduce these issues?

What is the new behavior (if this is a feature change)?

This PR replaces the old dev container with a new and simpler one, leveraging some of the recent updates from VS Code Dev Containers (i.e. dev container "features").

This PR also resolves the pre-commit issues by replacing git://github.com/caitlinelfring/pre-commit-golang with https://github.com/caitlinelfring/pre-commit-golang. This got pre-commit working for me—I'm very curious if this still works for others!

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)

If contributors are still using the current dev container, they should be able to just "Rebuild Container" in VS Code to start using the updated one.

If the pre-commit change also looks good and is accepted, contributors may need to run another pre-commit install to reflect the change.

Other information:

Please let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant