refactor UT to make it easier to test glob expansion #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a small UT refactor to make it easier to add future sub-tests in
TestParseArgs. Each test case is now executed as a sub-test. This is used to add UTs in #211. The purpose of this PR is to show the refactor without changing the set of UTs.What is the current behavior? (You can also link to an open issue here)
Currently, there are no sub-tests for file glob patterns.
What is the new behavior (if this is a feature change)?
No change.
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
Other information: