Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflow vars #34

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix workflow vars #34

wants to merge 3 commits into from

Conversation

emmyoop
Copy link
Contributor

@emmyoop emmyoop commented Dec 2, 2024 •
edited
Loading

Github does not allow anything stored as a secret in their UI to be passed as a variable.

This change uses variables instead of secrets for user, role, database and warehouse.

Note: This requires a change in the repo settings for these values. They need to be set as repository variables instead of respository secrets.

@emmyoop emmyoop marked this pull request as draft December 2, 2024 17:32
@emmyoop emmyoop had a problem deploying to Approve Integration Tests December 2, 2024 17:32 — with GitHub Actions Failure
@emmyoop emmyoop had a problem deploying to Approve Integration Tests December 2, 2024 17:34 — with GitHub Actions Failure
@emmyoop emmyoop changed the title add comment Fix workflow vars Dec 2, 2024
@emmyoop emmyoop had a problem deploying to Approve Integration Tests December 2, 2024 17:39 — with GitHub Actions Failure
@emmyoop
Copy link
Contributor Author

emmyoop commented Dec 2, 2024

Do you want ci_dbt_text_package.yml to trigger off pull_request (current config) or pull_request_target (matches ci_test_package.yml)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emmyoop