Add support for query tags from profiles.yml and environment variables #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-mirkin
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
There was a problem hiding this comment.
Thanks for opening the PR @maddoc1!
Will let @NiallRees own the review.
Functionality wise seems like two helpful additions. My only concern is i'm not quite sure what the implications are of starting out by populating the query tag from the current values set in the session - will let Niall comment here.
| @@ -11,6 +32,8 @@ | |||
| {% set query_tag = {} %} {# If the user has set the query tag config as a non mapping type, start fresh #} | |||
| {% endif %} | |||
|
|
|||
| {% do query_tag.update(session_query_tag_json) %} | |||
| {% do query_tag.update(env_var_query_tags) %} | |||
|
|
|||
| {%- do query_tag.update( | |||
There was a problem hiding this comment.
@NiallRees will defer this review to you
alex-mirkin
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
Co-authored-by: Ian Whitestone <[email protected]>
alex-mirkin
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
NiallRees
reviewed
Jan 18, 2024
macros/query_tags.sql
Outdated
| @@ -3,6 +3,27 @@ | |||
| {%- endmacro %} | |||
|
|
|||
| {% macro default__set_query_tag() -%} | |||
| {# Get session level query tag #} | |||
| {% set session_query_tag = get_current_query_tag() %} | |||
| {% set session_query_tag_json = {} %} | |||
There was a problem hiding this comment.
Suggested change
| {% set session_query_tag_json = {} %} | |
| {% set session_query_tag_json = {} %} |
let's rename this to 'session_query_tag_parsed' because it's not json once it's been fromjson'd?
NiallRees
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
NiallRees
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
NiallRees
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if I want to extend the query tags, only the ones from the model's config are added.
If I have a query tag in my connection profile in the
profiles.ymlfile - they are ignored.I've added the support to fetch the query tag from
profiles.ymlfile as well as from environment variables.The list of the environment variables to get the tags from is defined by a new project variable:
env_vars_to_query_tag_list.