Added CORS helper w tests #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmacartney
force-pushed
the
cors-helper
branch
from
a889ba6
to
e5b9e88
Compare
ianmacartney
approved these changes
Aug 7, 2024
|
|
||
| ```typescript | ||
| import { getFact } from "./myHttpApi"; | ||
| import { corsHttpRouter } from "./helpers/corsHttpRouter"; |
There was a problem hiding this comment.
Suggested change
| import { corsHttpRouter } from "./helpers/corsHttpRouter"; | |
| import { corsHttpRouter } from "convex-helpers/server/corsHttpRouter"; |
| @@ -772,3 +773,138 @@ import { useQuery } from "convex-helpers/react/cache/hooks"; | |||
|
|
|||
| const users = useQuery(api.users.getAll); | |||
| ``` | |||
|
|
|||
| ## HttpRouter with automatic CORS support | |||
There was a problem hiding this comment.
this is long enough that we can just make this the stack article and have a short paragraph, code snippet, and link to that stack post here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This added the CORS HttpRouter helper to the package. It includes tests and example usage, and README updates.