Add a metric for the size of the isolate pool (#33629)

GitOrigin-RevId: b93c1eaf4410e216b826f38a2399cfea0ecc7081
get-convex · Jan 24, 2025 · 4418308 · 4418308
1 parent 73ae005
commit 4418308
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/crates/isolate/src/client.rs b/crates/isolate/src/client.rs
@@ -160,6 +160,7 @@ use crate::{
     metrics::{
         self,
         log_aggregated_heap_stats,
+        log_pool_max,
         log_pool_running_count,
         log_worker_stolen,
         queue_timer,
@@ -1153,6 +1154,7 @@ impl<RT: Runtime, W: IsolateWorker<RT>> SharedIsolateScheduler<RT, W> {
     }
 
     pub async fn run(mut self, receiver: CoDelQueueReceiver<RT, Request<RT>>) {
+        log_pool_max(self.worker.config().name, self.max_workers);
         let mut receiver = receiver.fuse();
         let mut report_stats = self.rt.wait(*HEAP_WORKER_REPORT_INTERVAL_SECONDS);
         loop {

diff --git a/crates/isolate/src/metrics.rs b/crates/isolate/src/metrics.rs
@@ -71,6 +71,19 @@ pub fn log_pool_running_count(name: &'static str, count: usize, client_id: &str)
     );
 }
 
+register_convex_gauge!(
+    ISOLATE_POOL_MAX_INFO,
+    "How many isolate workers can be running",
+    &["pool_name"]
+);
+pub fn log_pool_max(name: &'static str, count: usize) {
+    log_gauge_with_labels(
+        &ISOLATE_POOL_MAX_INFO,
+        count as f64,
+        vec![StaticMetricLabel::new("pool_name", name)],
+    );
+}
+
 register_convex_gauge!(
     ISOLATE_POOL_ALLOCATED_COUNT_INFO,
     "How many isolate workers have been allocated",