Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate imports #20

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix duplicate imports #20

merged 1 commit into from
Mar 21, 2024

Conversation

abzrg
Copy link
Contributor

@abzrg abzrg commented Mar 21, 2024

Hi, and thanks for sharing the source.

Mapping module was imported twice in foamlib/_cases.py.

`Mapping` module was imported twice.
@abzrg
Copy link
Contributor Author

abzrg commented Mar 21, 2024

I've noticed that with the help of flake8. I think using a linter like that could be helpful.
If you want to use it and add the necessary configuration to pyproject.toml I can help with that.

@gerlero gerlero merged commit 3a3fa39 into gerlero:main Mar 21, 2024
15 checks passed
@gerlero
Copy link
Owner

gerlero commented Mar 21, 2024

Thanks! Good catch.

I've noticed that with the help of flake8. I think using a linter like that could be helpful.
If you want to use it and add the necessary configuration to pyproject.toml I can help with that.

Sure, go ahead! It should also be configured to run on GitHub Actions (but I can take care of that part if you can't)

@abzrg
Copy link
Contributor Author

abzrg commented Mar 21, 2024

Ok. Great!

@abzrg abzrg deleted the fix_import branch March 21, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants