[GEOT-7598] Update PMD to version 7.2

[aaime]

Pairs with:

• Updating PMD to 7.2.0 GeoWebCache/geowebcache#1279
• [GEOS-11433] Upgrade maven-pmd-plugin to 3.23.0 and PMD 7.2.x geoserver/geoserver#7577

Checklist

• I have read the contribution guidelines.
• I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• First PR targets the main branch (backports managed later; ignore for branch specific issues).
• Avoid Java 9+ split packages.
• All the build checks are green (see automated QA checks).

For core and extension modules:

• New unit tests have been added covering the changes.
• Documentation has been updated (if change is visible to end users).
• There is an issue in GeoTools Jira (except for changes not visible to end users).
• Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
• Bug fixes and small new features are presented as a single commit.
• The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

[mprins]

@aaime The "Creating annotations for /home/runner/work/geotools/geotools/modules/plugin/iau-wkt/target/pmd.xml" messages are perhaps a result of a GH permissions problem because you are working from a personal repo/branch and the action provided in the PR is trying to write (comments) in a different target repo, whereas in geoserver/geoserver#7577 the PR branch is in the target repo

see eg. https://stackoverflow.com/questions/77867138/commenting-build-results-on-a-pr-from-a-forked-repo-with-github-actions

[aaime]

@mprins good point but then... does it mean the annotations will fail for everyone making PRs from their fork?
That would not be workable, all QA builds would fail and devs would stop checking their results....

[mprins]

I'm not sure... we could always look into using a PAT like the backport workflow

[mprins]

actually, I think GH normally runs the workflow from the main (target) branch, unless a PR changes the workflow

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[aaime]

Dropping this one for now, want to prioritize Palantir and then try to use OpenRewrite to automate some of the fixes.