-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoCSS parser implementation #2
base: master
Are you sure you want to change the base?
Conversation
- add geocss to json utils - test read style with simple fill symbolizer
Thanks for providing your work and for your summary, what is missing @allyoucanmap. This helps a lot and makes it easier for others to continue on this. Very much appreciated 👍 |
Will someone continue to work on this? That'd be much appreciated |
@marcjansen I'm sorry to come back so late to this PR. After the implementation of this branch we tried the parser by installing it as a github repository in our application and the functionality developed was fullfilling our requirements. Unfortunately I could not spend additional time to complete all the other features listed in the description and this seems a blocker for the merge of the PR in this repo. We currently need to create an npm package for this parser and for this reason we published it starting from our fork under a different scope to avoid conflicts with names ( |
This PR introduces base write and read functionality for the parser.
It is still incomplete and limited in some parts that could be improved later. I'll try to summarize what's missing or needed below:
[ '||', ... 0 [ '&&', ... 1 [ '||' or '&&' ... 2 ] ] ]
. This is because I'm trying to follow the selector structure (see: GeoCSS filter doc). I'm aware it's possible to use nested parentheses like this[ type = 'e' and class = 'd' or ( position = 'a' or id = 'd') ]
inside the selector but currently it's not supported (see flat-geo-css)attribute not in ( 'value' )
orattribute not like 'value'
orattribute is not null
(this part needs some investigation).StrMatchesFunctionFilter
implementationconnected to issue geostyler/geostyler#1285