Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize layers/groups management in TOC #10247 #10609

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rowheat02
Copy link
Contributor

Description

fixes: #10247.
Some old maps and exports have groups in legacy format which shows some bugs like those mentioned in #10247.
Old formats can be converted to new standard formats with UI-wise invisible default group as a parent of all groups.

legacyGroups = [
  { id: '1', name: 'Group 1' },
 { id: DEFAULT_GROUP_ID }
 ];

newStandardFormat=[
      {
          id: <DEFAULT_GROUP_ID>,
         name: <DEFAULT_GROUP_ID>,
        nodes: [
             { id: '1', name: 'Group 1' },
             { id: 'DEFAULT_GROUP_ID.<uuid>' } // Unique UUID generated
         ],
        expanded: true
    }
 ]
 

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#10247
There are some interactivity bugs on TOC in old maps and exports.

What is the new behavior?

There are no interactivity bugs on TOC in old maps and exports.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02
Copy link
Contributor Author

rowheat02 commented Oct 10, 2024

@tdipisa

@tdipisa tdipisa added this to the 2024.02.01 milestone Oct 14, 2024
@tdipisa tdipisa added Internal enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch enhancement Internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize layers/groups management in TOC
2 participants