Fix saving workspace services not working with pgconfig #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving the workspace services not working with pgconfig when
caching is enabled. `CachingGeoServerFacade` assumed there's
nothing to do when a `ServiceInfo` is added for a workspace,
but it was caching the `null` value, which is expected to save
db roundtrips.
- Add missing treatment of `ServiceInfoAdded` and `SettingInfoAdded`
to `CachingGeoServerFacade`.
- Add referential integrity for settingsinfo and serviceinfo
Now the flyway migration will add referential integrity for:
- `settingsinfo(workspace) -> workspaceindo(id)`
- `serviceinfo(workspace) -> workspaceinfo(id)`
And unique indexes for:
- `settingsinfo(workspace)`
- `serviceinfo("@type", workspace)`
As a side effect of the caching facade returning null once a
`ServiceInfo` as added, you could add multiple services of the
same kind for a workspace. The referential integrity checks will
avoid that, and the FlyWay migration will delete existing duplicates.
groldan
deleted the
bug/caching_add_service_and_settings_wont_clear_cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the workspace services not working with pgconfig when caching is enabled.
CachingGeoServerFacadeassumed there's nothing to do when aServiceInfois added for a workspace, but it was caching thenullvalue, which is expected to save db roundtrips.Add missing treatment of
ServiceInfoAddedandSettingInfoAddedtoCachingGeoServerFacade.Add referential integrity for settingsinfo and serviceinfo
Now the flyway migration will add referential integrity for:
settingsinfo(workspace) -> workspaceindo(id)serviceinfo(workspace) -> workspaceinfo(id)And unique indexes for:
settingsinfo(workspace)serviceinfo("@type", workspace)As a side effect of the caching facade returning null once a
ServiceInfoas added, you could add multiple services of the same kind for a workspace. The referential integrity checks will avoid that, and the FlyWay migration will delete existing duplicates.Fixes #560