Add acceptance tests for the jdbcconfig catalog backend #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groldan
force-pushed
the
build/acceptance_jdbcconfig
branch
15 times, most recently
from
531eb7a
to
89dc052
Compare
Add `acceptance-tests-jdbcconfig` make target to test against the jdbcconfig catalog backend. The `acceptance-tests-*` targets change the docker compose project name so the volumes created don't interfere with the ones used during development. Hence new scripts have been added to the `compose/` folder: * `acceptance_datadir` * `acceptance_pgconfig` * `acceptance_jdbcconfig` That allow to run the appropriate `docker compose -f...` and set up the required env variables for each case, like to override the project name and hence the volume names, and to perform manual operations without having to dig up which parameters to use (e.g. `./acceptance_datadir ps`, etc.). The pull request github actions job is modified to upload jar files and download to build the images wihout re-packaging.
groldan
force-pushed
the
build/acceptance_jdbcconfig
branch
from
89dc052
to
b4bc6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
acceptance-tests-jdbcconfigmake target to test against the jdbcconfig catalog backend.The
acceptance-tests-*targets change the docker compose project name so the volumes created don't interfere with the ones used during development. Hence new scripts have been added to thecompose/folder:acceptance_datadiracceptance_pgconfigacceptance_jdbcconfigThat allow to run the appropriate
docker compose -f...and set up the required env variables for each case, like to override the project name and hence the volume names, and to perform manual operations without having to dig up which parameters to use (e.g../acceptance_datadir ps, etc.).