-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDAL base docker image #538
base: main
Are you sure you want to change the base?
Conversation
|
Update src/apps/base-images/gdal/Dockerfile Co-authored-by: Daniel Koch <[email protected]>
Just FYI as @aaime mentioned this on discourse: adoptium/containers#641 Seems that using temurin base images has performance issues with JPEG encoding, so on a long term we should try to optimize this. I am planning to start a discussion on the discourse developer forum soon. Also to find a common gdal base image (without JPEG performance issues) that can also be used for geoserver vanilla. |
So, correct me if I'm wrong. I totally agree on having same root base image with GDAL (for GSCloud as much as standard Geoserver) On any case, I would avoid to build based on a specific app container or Java btw, in GSCloud, the "apps" dont use Tomcat :). So using Tomcat in std Geoserver is a matter of a decision on the std Geoserver docker image, if we plan to share same base images, we need to agree on keep it agnostic of some high-level layers definitions, and just agree on the basic ones (OS, Java, GDAL). Count me for getting this done |
update: building the gdal lib ourselves in a github actions workflow takes over 2hs, so not too fond of it. Meanwhile, my current experimental branch is using the latest ( There are two of them:
The Btw, |
Why not using the full as multistage and grabbing all the necessary stuff (libgdal, libgdaljni, the jar native glue) from there ? even if the .so and the jar should be compatible across both full & small images, at least you will have everything you need in one go. |
agree with @pmauduit , using the full as builder and getting what we think it's useful sounds like a good approach. |
I'm not sure I understand. The small image already have libgdal and apparently a smaller list of supported formats. |
What I meant is that I would rather use all the binary materials from the same image, instead of mixing them, as you are sure that the jni bindings will work with the raw GDAL lib from the same place. But if you intend to use the small (because smaller binary size, less supported formats) on purpose, then I have no idea. |
For references, check PR