Remove all superfluously overridden methods from CatalogPlugin #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CatalogPlugin` started by only implementing `Catalog` and hence duplicated most of upstream's `CatalogImpl` functionality. Then it was required for it to extend `CatalogImpl` instead, due to code in GeoServer assuming the `Catalog` **is A** `CatalogImpl`, but the overridden methods that did the same weren't removed. This leaves `CatalogPlugin` much cleaner and it's easier to see how it exactly differ from its superclass.
groldan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CatalogPluginstarted by only implementingCatalogand hence duplicated most of upstream'sCatalogImplfunctionality. Then it was required for it to extendCatalogImplinstead, due to code in GeoServer assuming theCatalogis ACatalogImpl, but the overridden methods that did the same weren't removed.This leaves
CatalogPluginmuch cleaner and it's easier to see how it exactly differ from its superclass.