refactor: fix various minors (typos etc)

compose/pgbouncer.yml

@@ -1,4 +1,4 @@
-# for simplicity, use one pgbouncer instance per databse
+# for simplicity, use one pgbouncer instance per database
 # postgis -> postgis_pg
 # acldb -> acldb_pg
 # pgconfigdb -> pgconfigdb_pg

src/catalog/backends/common/src/main/java/org/geoserver/cloud/security/CloudGeoServerSecurityManager.java

@@ -33,7 +33,7 @@
  * Extends {@link GeoServerSecurityManager} to {@link #fireRemoteChangedEvent(String) notify} other
  * services of changes to the security configuration happened on the currently running service, and
  * to {@link #onRemoteSecurityConfigChangeEvent listen to} those events to {@link
- * GeoServerSecurityManager#reload() reload} the security config when other serice made a change.
+ * GeoServerSecurityManager#reload() reload} the security config when other service made a change.
  */
 @Slf4j(topic = "org.geoserver.cloud.security")
 public class CloudGeoServerSecurityManager extends GeoServerSecurityManager {

src/catalog/event-bus/src/main/java/org/geoserver/cloud/event/bus/RemoteGeoServerEventBridge.java

@@ -30,7 +30,6 @@
  *
  * @see #publishRemoteEvent(GeoServerEvent)
  * @see #publishLocalEvent(RemoteGeoServerEvent)
- * @see RemoteGeoServerEventProcessor
  */
 @Slf4j(topic = "org.geoserver.cloud.event.bus.bridge")
 public class RemoteGeoServerEventBridge implements DisposableBean {

src/catalog/event-bus/src/test/java/org/geoserver/cloud/event/bus/BusAmqpIntegrationTests.java

@@ -151,7 +151,7 @@ public void before() {
         BusEventCollector remoteAppEvents = remoteAppContext.getBean(BusEventCollector.class);
         this.eventsCaptor = new EventsCaptor(localAppEvents, remoteAppEvents);
 
-        eventsCaptor.stop().clear().capureEventsOf(InfoEvent.class);
+        eventsCaptor.stop().clear().captureEventsOf(InfoEvent.class);
 
         testData = CatalogTestData.empty(() -> catalog, () -> geoserver).initialize();
     }
@@ -299,7 +299,7 @@ protected <T extends Info> RemoteGeoServerEvent testRemoteCatalogInfoAddEvent(
     protected <T extends Info> RemoteGeoServerEvent testRemoteAddEvent(
             T info, Consumer<T> addOp, Class<? extends InfoAdded> eventType) {
 
-        this.eventsCaptor.stop().clear().capureEventsOf(eventType);
+        this.eventsCaptor.stop().clear().captureEventsOf(eventType);
         eventsCaptor.start();
         addOp.accept(info);
 
@@ -424,7 +424,7 @@ protected static class EventsCaptor {
         final @Getter BusEventCollector local;
         final @Getter BusEventCollector remote;
 
-        public <E extends InfoEvent> EventsCaptor capureEventsOf(Class<E> type) {
+        public <E extends InfoEvent> EventsCaptor captureEventsOf(Class<E> type) {
             local.capture(type);
             remote.capture(type);
             return this;

src/catalog/events/src/test/java/org/geoserver/cloud/config/catalog/events/CatalogApplicationEventsConfigurationTest.java

@@ -71,7 +71,7 @@ class CatalogApplicationEventsConfigurationTest {
     private CatalogTestData testData;
 
     public @BeforeEach void before() {
-        listener.setCapureEventsOf(InfoEvent.class);
+        listener.setCaptureEventsOf(InfoEvent.class);
         catalog.dispose();
         listener.clear();
         testData = CatalogTestData.empty(() -> catalog, () -> geoserver).initialize();

src/catalog/plugin/src/main/java/org/geoserver/catalog/plugin/CatalogInfoLookup.java

@@ -53,7 +53,7 @@
 
 /**
  * A support index for {@link DefaultMemoryCatalogFacade}, can perform fast lookups of {@link
- * CatalogInfo} objects by id or by "name", where the name is defined by a a user provided mapping
+ * CatalogInfo} objects by id or by "name", where the name is defined by a user provided mapping
  * function.
  *
  * <p>The lookups by predicate have been tested and optimized for performance, in particular the
@@ -81,7 +81,8 @@ abstract class CatalogInfoLookup<T extends CatalogInfo> implements CatalogInfoRe
             s -> new NameImpl(s.getWorkspace().getId(), s.getName());
 
     /**
-     * The name uses the namspace id as it does not need to be updated when the namespace is renamed
+     * The name uses the namespace id as it does not need to be updated when the namespace is
+     * renamed
      */
     static final Function<ResourceInfo, Name> RESOURCE_NAME_MAPPER =
             r -> new NameImpl(r.getNamespace().getId(), r.getName());

src/catalog/plugin/src/main/java/org/geoserver/config/plugin/GeoServerImpl.java

@@ -561,7 +561,7 @@ public void reload(Catalog newCatalog) throws Exception {
                     ((CatalogImpl) catalog).sync((CatalogImpl) newCatalog);
                     ((CatalogImpl) catalog).resolve();
                 } else {
-                    callGeoServeLoaderReload();
+                    callGeoServerLoaderReload();
                 }
             }
         } finally {
@@ -579,7 +579,7 @@ public void reload(Catalog newCatalog) throws Exception {
         }
     }
 
-    private void callGeoServeLoaderReload() throws Exception {
+    private void callGeoServerLoaderReload() throws Exception {
         GeoServerLoaderProxy loaderProxy = GeoServerExtensions.bean(GeoServerLoaderProxy.class);
         if (loaderProxy == null) {
             GeoServerLoader geoServerLoader = GeoServerExtensions.bean(GeoServerLoader.class);

src/catalog/plugin/src/test/java/org/geoserver/cloud/test/ApplicationEventCapturingListener.java

@@ -24,7 +24,7 @@ public class ApplicationEventCapturingListener {
 
     private Class<?> eventType = ApplicationEvent.class;
 
-    public void setCapureEventsOf(Class<?> type) {
+    public void setCaptureEventsOf(Class<?> type) {
         this.eventType = type;
     }