qa: JUnit4 @ignored and JUnit5 @disabled annotations should be used t…

…o disable tests and should provide a rationale

src/catalog/backends/pgsql/src/test/java/org/geoserver/cloud/backend/pgsql/resource/PgsqlResourceTest.java

@@ -22,7 +22,6 @@
 import org.junit.experimental.theories.Theories;
 import org.junit.rules.TemporaryFolder;
 import org.junit.runner.RunWith;
-import org.springframework.context.annotation.Bean;
 import org.springframework.integration.jdbc.lock.DefaultLockRepository;
 import org.springframework.integration.jdbc.lock.JdbcLockRegistry;
 import org.springframework.integration.jdbc.lock.LockRepository;
@@ -127,7 +126,6 @@ private LockRegistry pgsqlLockRegistry() {
         return new JdbcLockRegistry(pgsqlLockRepository());
     }
 
-    @Bean
     LockRepository pgsqlLockRepository() {
         DefaultLockRepository lockRepository =
                 new DefaultLockRepository(dataSource, "test-instance");
@@ -177,14 +175,14 @@ protected Resource getResource(String path) throws Exception {
         return store.get(path);
     }
 
-    @Ignore
     @Override
+    @Ignore("This behaviour is specific to the file based implementation")
     public void theoryAlteringFileAltersResource(String path) throws Exception {
         // disabled
     }
 
-    @Ignore
     @Override
+    @Ignore("This behaviour is specific to the file based implementation")
     public void theoryAddingFileToDirectoryAddsResource(String path) throws Exception {
         // disabled
     }

src/catalog/plugin/src/test/java/org/geoserver/catalog/plugin/CatalogConformanceTest.java

@@ -2203,7 +2203,8 @@ void testAddWMTSStore() {
      * Revisit.
      */
     @Test
-    @Disabled
+    @Disabled(
+            "This test cannot work, the catalog subsystem is not thread safe, that's why we have the configuration locks. Re-enable when the catalog subsystem is made thread safe.")
     public void testGetLayerByIdWithConcurrentAdd() throws Exception {
         addDataStore();
         addNamespace();