Evict all authorizations on rule events and do not cache authroizations with no matching rules #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns with no matching rules Caching authrization responses with no matching rules results in cached entries not being evicted when the request starts matching a rule. In any case, evict all authorizations upon rule events because the affected rule ids held in AccessInfo is not enough to cherry pick which ones to evict. A rule change may change the affected rules.
groldan
force-pushed
the
fix/dont_cache_accessinfo_with_no_matching_rules
branch
from
fb9774f
to
aae26e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching authrization responses with no matching rules results in cached entries not being evicted when the request starts matching a rule.
In any case, evict all authorizations upon rule events because the affected rule ids held in AccessInfo is not enough to cherry pick which ones to evict. A rule change may change the affected rules.