Skip to content

Commit

Permalink
Merge pull request #75 from groldan/accessmanager_adminrequest
Browse files Browse the repository at this point in the history 
ResourceAccesManager: allow admin access to layers belonging to an adminable workspace
  • Loading branch information
@groldan
groldan authored Aug 19, 2024
2 parents f72f6f8 + 455503f commit 8560d15
Showing 1 changed file with 79 additions and 58 deletions.
137 changes: 79 additions & 58 deletions ...anager/src/main/java/org/geoserver/acl/plugin/accessmanager/ACLResourceAccessManager.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/
package org.geoserver.acl.plugin.accessmanager;

import static org.geoserver.acl.authorization.AccessInfo.ALLOW_ALL;
import static org.geoserver.acl.domain.rules.GrantType.ALLOW;
import static org.geoserver.acl.domain.rules.GrantType.DENY;
import static org.geoserver.acl.domain.rules.GrantType.LIMIT;
Expand Down Expand Up @@ -46,6 +47,7 @@
import org.geoserver.platform.ExtensionPriority;
import org.geoserver.security.AbstractResourceAccessManager;
import org.geoserver.security.AccessLimits;
import org.geoserver.security.AdminRequest;
import org.geoserver.security.CatalogMode;
import org.geoserver.security.CoverageAccessLimits;
import org.geoserver.security.DataAccessLimits;
Expand Down Expand Up @@ -206,6 +208,10 @@ public boolean isWorkspaceAdmin(Authentication user, Catalog catalog) {
/** We expect the user not to be null and not to be admin */
private boolean isWorkspaceAdmin(Authentication user, WorkspaceInfo workspace) {
String workspaceName = workspace.getName();
return isWorkspaceAdmin(user, workspaceName);
}

private boolean isWorkspaceAdmin(Authentication user, String workspaceName) {
AccessSummary accessSummary = getAccessSummary(user);
return accessSummary.hasAdminWriteAccess(workspaceName);
}
Expand Down Expand Up @@ -279,6 +285,10 @@ static Stream<String> roles(Authentication user) {
return user.getAuthorities().stream().map(GrantedAuthority::getAuthority);
}

private boolean isAdminRequest() {
return null != AdminRequest.get();
}

private AccessLimits getAccessLimits(
Authentication user,
CatalogInfo info,
Expand All @@ -291,73 +301,68 @@ private AccessLimits getAccessLimits(
return buildAdminAccessLimits(info);
}

AccessRequest accessRequest = buildAccessRequest(workspace, layer, user);
AccessInfo accessInfo = getAccessInfo(accessRequest);

final Request req = Dispatcher.REQUEST.get();
final String service = req != null ? req.getService() : null;
final boolean isWms = "WMS".equalsIgnoreCase(service);
final boolean isWps = "WPS".equalsIgnoreCase(service);
final boolean layerGroupsRequested = CollectionUtils.isNotEmpty(containers);

AccessInfo accessInfo;
ProcessingResult processingResult = null;
if (isWms && !layerGroupsRequested) {
// is direct access we need to retrieve eventually present groups.
Collection<LayerGroupSummary> summaries = getGroupSummary(info);
if (!summaries.isEmpty()) {
boolean allOpaque = allOpaque(summaries);
boolean noneSingle = noneSingle(summaries);
// all opaque we deny and don't perform any resolution of group limits.
if (allOpaque) {
accessInfo = accessInfo.withGrant(DENY);
} else if (noneSingle) {
// if a single group is present we don't apply any limit from containers.
processingResult =
getContainerResolverResult(
info, layer, workspace, user, null, summaries);

if (isAdminRequest() && isWorkspaceAdmin(user, workspace)) {
accessInfo = ALLOW_ALL;
} else {
AccessRequest accessRequest = buildAccessRequest(workspace, layer, user);
accessInfo = getAccessInfo(accessRequest);

final Request req = Dispatcher.REQUEST.get();
final String service = req != null ? req.getService() : null;
final boolean isWms = "WMS".equalsIgnoreCase(service);
final boolean isWps = "WPS".equalsIgnoreCase(service);
final boolean layerGroupsRequested = CollectionUtils.isNotEmpty(containers);

if (isWms && !layerGroupsRequested) {
// is direct access we need to retrieve eventually present groups.
Collection<LayerGroupSummary> summaries = getGroupSummary(info);
if (!summaries.isEmpty()) {
boolean allOpaque = allOpaque(summaries);
boolean noneSingle = noneSingle(summaries);
// all opaque we deny and don't perform any resolution of group limits.
if (allOpaque) {
accessInfo = accessInfo.withGrant(DENY);
} else if (noneSingle) {
// if a single group is present we don't apply any limit from containers.
processingResult =
getContainerResolverResult(
info, layer, workspace, user, null, summaries);
}
}
} else if (layerGroupsRequested) {
// layer is requested in context of a layer group, we need to process the
// containers limits.
processingResult =
getContainerResolverResult(
info, layer, workspace, user, containers, List.of());
}
} else if (layerGroupsRequested) {
// layer is requested in context of a layer group, we need to process the
// containers limits.
processingResult =
getContainerResolverResult(info, layer, workspace, user, containers, List.of());
}

if (isWps) {
if (layerGroupsRequested) {
log(
WARNING,
"Don't know how to deal with WPS requests for group data. Won't dive into single process limits.");
} else {
WPSAccessInfo resolvedAccessInfo =
wpsHelper.resolveWPSAccess(accessRequest, accessInfo);
if (resolvedAccessInfo != null) {
accessInfo = resolvedAccessInfo.getAccessInfo();
processingResult = wpsProcessingResult(accessInfo, resolvedAccessInfo);
if (isWps) {
if (layerGroupsRequested) {
log(
FINE,
"Got WPS access {0} for layer {1} and user {2}",
accessInfo,
layer,
getUserNameFromAuth(user));
WARNING,
"Don't know how to deal with WPS requests for group data. Won't dive into single process limits.");
} else {
WPSAccessInfo resolvedAccessInfo =
wpsHelper.resolveWPSAccess(accessRequest, accessInfo);
if (resolvedAccessInfo != null) {
accessInfo = resolvedAccessInfo.getAccessInfo();
processingResult = wpsProcessingResult(accessInfo, resolvedAccessInfo);
log(
FINE,
"Got WPS access {0} for layer {1} and user {2}",
accessInfo,
layer,
getUserNameFromAuth(user));
}
}
}
}

AccessLimits limits;
if (info instanceof LayerGroupInfo) {
limits = buildLayerGroupAccessLimits(accessInfo);
} else if (info instanceof ResourceInfo) {
limits = buildResourceAccessLimits((ResourceInfo) info, accessInfo, processingResult);
} else if (info instanceof LayerInfo) {
limits =
buildResourceAccessLimits(
((LayerInfo) info).getResource(), accessInfo, processingResult);
} else {
throw new IllegalArgumentException(
"Expected LayerInfo|LayerGroupInfo|ResourceInfo, got " + info);
}
AccessLimits limits = buildLayerLimits(info, accessInfo, processingResult);

log(
FINE,
Expand All @@ -369,6 +374,22 @@ private AccessLimits getAccessLimits(
return limits;
}

private AccessLimits buildLayerLimits(
CatalogInfo info, AccessInfo accessInfo, ProcessingResult processingResult) {

if (info instanceof ResourceInfo) {
ResourceInfo resource = (ResourceInfo) info;
return buildResourceAccessLimits(resource, accessInfo, processingResult);
}
if (info instanceof LayerInfo) {
ResourceInfo resource = ((LayerInfo) info).getResource();
return buildLayerLimits(resource, accessInfo, processingResult);
}
if (info instanceof LayerGroupInfo) return buildLayerGroupAccessLimits(accessInfo);
throw new IllegalArgumentException(
"Expected LayerInfo|LayerGroupInfo|ResourceInfo, got " + info);
}

private ProcessingResult wpsProcessingResult(
AccessInfo accessInfo, WPSAccessInfo wpsAccessInfo) {
ProcessingResult processingResult;
Expand Down

0 comments on commit 8560d15

Please sign in to comment.