-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added example script to validate GEOS-Chem photolysis reactions #338
Conversation
gcpy/examples/geos-chem/check_photolysis.py - Example script that checks the consistency of the photolysis reactions in GEOS-Chem by looking at the FJX_j2j.dat, species_database.yml, and fullchem.eqn files. gcpy/examples/__init__.py CHANGELOG.md - Updated accordingly NOTE: Needs a further commit to add argument parsing. Signed-off-by: Bob Yantosca <[email protected]>
gcpy/examples/__init__.py - Change geos-chem folder name to geoschem to avoid error gcpy/examples/geoschem/check_photolysis.py - Moved gcpy/examples/geos-chem/check_photolysis.py here - Added argument parsing via argparse library - Updated comments and trimmed trailing whitespace Signed-off-by: Bob Yantosca <[email protected]>
@yantosca, thanks for putting this together. I have a few questions about the output.
Any species that have
|
I will double check this. Like you said, it may just be coinicidence.
You are correct. We should remove those.
We will but this is a temporary solution for now. |
I made changes in GEOS-Chem to fix the J-value diagnostics resulting from mismatches in the files. I wrote my own script to figure out the mismatches to keep it simple. My approach is more command line style, amenable to notebooks. I wonder if we are going to put an example for this whether we should do that as well, so it is easier to read and do data analysis with.
The output looks like this:
|
Thanks @lizziel. If you want I can close this PR and have you add a new PR with your script. |
Okay, I am going to let the dust settle on the J-values diagnostics and species database before adding any example scripts to GCPy. We are still figuring out what changes will be made for the diagnostic and whatever is done will affect the checks needed. GCST can use local scripts to check and I don't think we need to share the scripts on GCPy just yet. |
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR adds a new script
gcpy/examples/geoschem/check_photolysis.py
, which validates the GEOS-Chem photolysis mechanism by checking thespecies_database.yml
,FJX_j2j.dat
, andfullchem.eqn
(orcustom.eqn
) files.Expected changes
When calling the script with:
The following output is generated:
Output such as this denotes a succesfully-configured photolysis mechanism. All of the photo species should have
Is_Photolysis: true
in thespecies_database.yml
file. Mismatches of species will generate an error message.