Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace stalebot with "stale" GitHub action #410

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Replace stalebot with "stale" GitHub action #410

merged 1 commit into from
Apr 22, 2024

Conversation

yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This PR does the following:

  1. Updates the list of labels for issues/PRs that should not be marked as "stale"
  2. Retires "stalebot" and corresponding config files
  3. Uses the GitHub Action "stale" to mark issues as stale, and adds corresponding config file

Expected changes

This is a zero-diff update that only affects when GitHub issues are marked as "stale".

Related Github Issue(s)

@yantosca
Now use the "stale" GitHub action instead of StaleBot
3d50d8f 
.github/no-response.yml
.github/stale.yml
- Removed

.github/workflows/stale.yml
- Configuration file for GitHub "stale" action, which replaces
  StaleBot.  Use the most recent list of issue/PR labels to never
  be marked stale.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added the topic: GitHub Related to GitHub templates or actions label Apr 22, 2024
@yantosca yantosca added this to the 14.4.0 milestone Apr 22, 2024
@yantosca yantosca requested a review from msulprizio April 22, 2024 17:50
@yantosca yantosca self-assigned this Apr 22, 2024
@yantosca yantosca added the category: Bug Fix Fixes a previously-reported issue label Apr 22, 2024
This was referenced Apr 22, 2024
Merged
Merged
Closed
@yantosca yantosca mentioned this pull request Apr 22, 2024
Merged
1 task
msulprizio
msulprizio requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the base branch here be dev/14.4.0?

Also, this includes committing the submodule updates for GEOS-Chem (but not HEMCO) which we don't typically do in the super project PRs.

@yantosca
Copy link
Contributor Author

@msulprizio, yes, I could make a submodule update instructions list and we'd have to merge them in separately (maybe after this PR is merged).

@yantosca yantosca changed the base branch from main to dev/14.4.0 April 22, 2024 18:03
@yantosca
Copy link
Contributor Author

@msulprizio: The base branch is now dev/14.4.0.

@yantosca yantosca requested a review from msulprizio April 22, 2024 18:04
msulprizio
msulprizio approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now approved

@yantosca yantosca merged commit 807e340 into dev/14.4.0 Apr 22, 2024
@yantosca yantosca deleted the feature/update-stalebot branch April 22, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msulprizio msulprizio msulprizio approved these changes

Assignees

@yantosca yantosca

Labels
category: Bug Fix Fixes a previously-reported issue topic: GitHub Related to GitHub templates or actions
Projects
None yet
Milestone
14.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yantosca @msulprizio