Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to min/max representation of empty AABB #184

Merged
merged 1 commit into from
Nov 5, 2024

Commits on Nov 5, 2024

  1. Revert back to min/max representation of empty AABB

    This reverts back to the min/max representation of empty AABB
    due to regressions introduced by the numerically more tame but
    not invariant for merging representation.
    
    To avoid regressing #161, it also adds a single check to avoid
    computing the distance to an empty envelope (of the root node
    of an empty tree). Integer coordinates are always prone to overflow
    but in the empty case we are forcing this onto the caller whereas
    every non-empty tree will have AABB that the caller supplied and
    where we can reasonably ask them to control for overflow or
    use a custom `Point` impl based on saturating arithmetic.
    adamreichold committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    20014b7 View commit details
    Browse the repository at this point in the history