-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark GeoTIFF read speeds #22
Draft
weiji14
wants to merge
8
commits into
main
Choose a base branch
from
benchmark_codspeed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statistics-driven micro-benchmarking library! Repo at https://github.com/bheisler/criterion.rs
Benchmark both the time and throughput for reading a 50MB file of various dtypes. GeoTIFF files were downloaded from https://s3.us-east-2.amazonaws.com/geotiff-benchmark-sample-files/geotiff_sample_files.tar.gz. See also https://github.com/kokoalberti/geotiff-benchmark.
Based on https://docs.codspeed.io/benchmarks/rust#running-the-benchmarks-in-your-ci, adapted to have a trigger that only runs when a `run/benchmark` label is in place, and includes a download/extract step for the sample GeoTIFF files.
Codspeed action only supports Ubuntu 20.04 and 22.04 at the moment.
Set benchmark group name to `read_geotiff_50MB`, and benchmark function names to `u8_dtype`, `i16_dtype`, `f32_dtype`.
Specifically byte_50m.tif, float32_50m.tif, int16_50m.tif.
From downloading the tar archive, extracting, and running the benchmark via `cargo bench`.
Ok, so the Codspeed Action (for tracking benchmarks over time) requires someone with admin permissions to install the CodspeedHQ GitHub App (see docs at https://docs.codspeed.io/importing-repositories). Have requested the install, and will re-run the benchmarks CI once that is enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measuring how fast it takes to read GeoTIFF files (in terms of duration/time and throughput), setting up a baseline level of performance as we work towards addressing #5.
run/benchmark
, on themain
branch, or onrelease
.To run locally:
Example output on my laptop:
References: