Add additional options #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
description concerning b9bcaca should be "add description of TypoScript options" |
georgringer
requested changes
May 4, 2020
| declare(strict_types=1); | ||
|
|
||
| namespace GeorgRinger\Noopener\Hooks; | ||
|
|
||
| ini_set('memory_limit','-1'); |
| $relAttributeArray = $this->defaultRelAttributeArray; | ||
| } | ||
|
|
||
| if ($this->conf['relAttribute']) { |
There was a problem hiding this comment.
shouldn't the upper useDefault be just an else part?
| $relAttributeArray = array_merge($relAttributeArray, explode(' ', $this->conf['relAttribute'])); | ||
| } | ||
|
|
||
| if ($this->conf['useCssClass'] && isset($params['tagAttributes']['class'])) { |
There was a problem hiding this comment.
what is the reason for that? don't get the feature?
| @@ -42,6 +134,22 @@ public function run(array &$params) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * initialize some basic variables from TypoScript configuration | |||
There was a problem hiding this comment.
shouldn't this be then in the __construct()
| $this->conf = $tsConfig['tx_noopener']; | ||
|
|
||
| if (isset($this->conf['useDefaultRelAttribute']) | ||
| && strtolower($this->conf['useDefaultRelAttribute']) === 'false' |
There was a problem hiding this comment.
check with bool instead of string compare with false
| assumed the defaut values shall still be removed the code looks then like this: | ||
| :: | ||
| config.tx_noopener { | ||
| useDefaultRelAttribute = false |
There was a problem hiding this comment.
either it is the given attributes or fallback, there is no need for a setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional options are described in the enriched Readme.rst
Used methods are TypoScript and CSS-classes where those can be configured for links.
See #4