Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added conversion of Pydantic's 'description' field into DRF's '… #23

Merged
merged 5 commits into from
May 27, 2024
Merged

feat: Added conversion of Pydantic's 'description' field into DRF's '… #23

merged 5 commits into from
May 27, 2024

Conversation

MrMika96
Copy link
Contributor

…help_text' field
#22

georgebv
georgebv requested changes May 26, 2024
View reviewed changes
Copy link
Owner

@georgebv georgebv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Can you please add unit tests to test fields with/without description?

src/drf_pydantic/parse.py Outdated Show resolved Hide resolved
@georgebv
Copy link
Owner

You can ignore the CI failure, codecov deprecated action version used to publish coverage.

@georgebv
Copy link
Owner

Everything looks good. Just format the code using ruff and we can merge.

@MrMika96
Copy link
Contributor Author

Everything looks good. Just format the code using ruff and we can merge.

Done.

@georgebv georgebv merged commit 275f31c into georgebv:main May 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgebv georgebv georgebv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrMika96 @georgebv