Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon location #677

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Favicon location #677

merged 1 commit into from
Dec 10, 2023

Conversation

f-necas
Copy link
Contributor

@f-necas f-necas commented Dec 4, 2023

Favicon location

This PR is used to change favicon to point to /favicon.ico url.

This is supposed to be the default location for geOrchestra's favicon.

Resolving :

Altering default behavior.

In order to change default location, we can implement it with a custom script, modyfing /favicon.ico infollowing html files to the new location using a tool like sed.

Files to change :

# /usr/local/tomcat
./webapps/mapstore/embedded.html
./webapps/mapstore/api.html
./webapps/mapstore/embeddedTemplate.html
./webapps/mapstore/geostory-embedded.html
./webapps/mapstore/index.html
./webapps/mapstore/dist/embedded.html
./webapps/mapstore/dist/geOrchestra.js
./webapps/mapstore/dist/geostory-embedded.html
./webapps/mapstore/dist/index.html
./webapps/mapstore/indexTemplate.html
./webapps/mapstore/geostory-embedded-template.html
./webapps/mapstore/apiTemplate.html

@fvanderbiest
Copy link
Member

LGTM, thanks Florian !
To be backported to stable branches as well

@fvanderbiest fvanderbiest merged commit 8220503 into master Dec 10, 2023
2 checks passed
@fvanderbiest fvanderbiest deleted the georchestra-favicon branch December 10, 2023 21:11
f-necas pushed a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants