docker - provide unzipped war #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvanderbiest
commented
Nov 12, 2023
| FROM alpine:latest as alpine | ||
| RUN apk --update add unzip && rm -rf /var/cache/apk/* | ||
| WORKDIR /tmp | ||
| COPY docker/MapStore-*.war mapstore.war |
There was a problem hiding this comment.
Note to the reviewer: the war file is provided by
edevosc2c
requested changes
Nov 13, 2023
fvanderbiest
added a commit
that referenced
this pull request
Nov 14, 2023
* docker - provide unzipped war * take into account edevos review
fvanderbiest
added a commit
that referenced
this pull request
Nov 14, 2023
* docker - provide unzipped war * take into account edevos review
This was referenced Nov 14, 2023
|
@fvanderbiest , @tdipisa told me that this pull request has broken their CI/CD. Could you please, both, share here how to fix this ? |
|
Maybe @tdipisa could send the errors given by his CI/CD so that we can understand what went wrong? |
|
Hi all, the reason why I didn't notify this here is because we still have to check what's going wrong and if we can fix this autonomously. I will let you know if needed. Don't worry. Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geOrchestra docker images are provided with unzipped webapps.
The current PR aligns MapStore-georchestra docker image with the other ones.
Example direct benefit - custom themes are easier to implement using docker:
A multi stage build is used to reduce the final image size - it does not have to embed the original war file.