Implemention of new WebComponent header #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
tkohr
reviewed
Nov 14, 2023
js/plugins/Header.jsx
Outdated
Comment on lines
31
to
32
| const georHeader = document.createElement("geor-header"); | ||
| const georHeaderScript = document.createElement("script"); |
There was a problem hiding this comment.
Just wondering if we couldn't put these elements in the index.html and then just set the script.src and attributes here,... also to prevent the check for multiple header creation above. But I guess this does not work?
tkohr
reviewed
Nov 14, 2023
js/plugins/Header.jsx
Outdated
| const georHeaderScript = document.createElement("script"); | ||
|
|
||
| georHeader.setAttribute("active-app", page); | ||
| georHeader.setAttribute("legacy-header", false); |
There was a problem hiding this comment.
Is this line necessary, to set the legacy-header equals false before the georHeader.setAttribute("legacy-header", legacy); below?
There was a problem hiding this comment.
It isn't, just forgot to remove it.
f-necas
changed the title
|
Also tested last week and it worked :-) |
This was referenced Dec 1, 2023
landryb
added a commit
to landryb/datadir
that referenced
this pull request
Dec 6, 2023
fvanderbiest
added a commit
to georchestra/datadir
that referenced
this pull request
Dec 10, 2023
f-necas
added a commit
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
georchestra/georchestra#4065
Implements the new georchestra/header in geoserver.
Main PR : georchestra/georchestra#4065