Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#651: Update MS to latest version (Phase III) #653

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

dsuren1
Copy link
Collaborator

@dsuren1 dsuren1 commented Sep 29, 2023

Description

This PR updates MS submodule to latest of 2023.02.xx

Issue

Testing

Note: zoomToLayer is set to false for Catalog plugin (existing config) (COG layer won't zoom to extent when added with bbox)

@dsuren1 dsuren1 added this to the MOM MS4 - Phase III milestone Sep 29, 2023
@dsuren1 dsuren1 self-assigned this Sep 29, 2023
@dsuren1 dsuren1 linked an issue Sep 29, 2023 that may be closed by this pull request
@landryb
Copy link
Member

landryb commented Sep 29, 2023

fwiw i've been able to deploy the debian package from https://github.com/georchestra/mapstore2-georchestra/actions/runs/6350369110 on a demo instance and i'm testing COG layers working fine there, including geosolutions-it/MapStore2#9469 (once you remember to tick Télécharger les métadonnées du fichier lors de la recherche in the catalog entry advanced options)

Copy link
Collaborator

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please :

  • Please update to the latest fixes coming up tomorrow. We have some fixes that we have to port.
  • pluginsConfig.json seems a little misaligned. In particular there are some correct differences, but also some misalignments that we could fix
    • swipe plugin missing as child of TOC
    • Settings do not have child version plugin anymore
    • other differences are correct, so we should not align them (e.g. Login - Version, different confiuguration for docs etc...)
    • mapviews and LongitudinalProfile seems to be removed in favor of GeoProcessing. It is a desired change ?

@dsuren1
Copy link
Collaborator Author

dsuren1 commented Oct 3, 2023

@offtherailz

  • swipe plugin missing as child of TOC

I'm not sure if this was intended, as these changes have been present for a long time. So I preferred to not add it.
(Anyway, I have added it now, as requested)

  • Settings do not have child version plugin anymore

This project has a custom version plugin and preferred to be in the settings.

  • mapviews and LongitudinalProfile seems to be removed in favor of GeoProcessing. It is a desired change ?

No. probably overwritten when replacing contents. (Added now)

@dsuren1
Copy link
Collaborator Author

dsuren1 commented Oct 3, 2023

@offtherailz

Please update to the latest fixes coming up tomorrow. We have some fixes that we have to port.

I have updated to latest MS (2023.02.xx). Are there still some fixes/commits expected to be in today?

@tdipisa
Copy link
Collaborator

tdipisa commented Oct 3, 2023

Just one @dsuren1 I will let you know as soon as the build is finished.

@offtherailz offtherailz merged commit 59e7d1d into georchestra:master Oct 3, 2023
1 check passed
dsuren1 added a commit to dsuren1/mapstore2-georchestra that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MS to latest version (Phase III)
4 participants