Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change proxy url path to root #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tkohr
Copy link
Contributor

@tkohr tkohr commented Mar 2, 2023

This PR changes proxy requests to be sent from the root path https://[mygeorchestra]/ instead of https://[mygeorchestra]/mapstore/

When trying to use an external layer (3dtiles in the occasion) via the proxy I stumbled over the fact that requests to the layer sent from https://[mygeorchestra]/mapstore/ are blocked by the georchestra security proxy.

Wondering if anybody has already successfully used the proxy with the current url within georchestra. If so, please correct me, I might be missing something.

@landryb
Copy link
Member

landryb commented Mar 2, 2023

mapstore itself uses its own proxy at /mapstore/proxy (hence the missing leading slash?) which is different from georchestra's internal proxy at /proxy. Iirc it's supposed to work too, and be used for urls not in useCORS list...

@tkohr
Copy link
Contributor Author

tkohr commented Mar 7, 2023

Ok, I didn't get the requests via the mapstore proxy ("url": "proxy/?url=") to work then (maybe due to missing configuration?). The same requests worked via the georchestra proxy ("url": "/proxy/?url="). I'm testing on https://github.com/georchestra/docker/tree/22.0

As the server I'm querying accepts CORS I finally don't use a proxy anymore.

Just opened this PR, in case anybody else stumbles on same problem and can confirm.

@f-necas f-necas self-requested a review May 28, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants