use as much webapps shortcut as possible #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanpommier
requested changes
Nov 22, 2023
templates/geonetwork/ogc-api-records/ogc-api-records-deployment.yaml
Outdated
Show resolved
Hide resolved
|
Oops I think I forgot to double-check, some webapps shortcut were not assigned correctly. |
|
Looks good to me. Did you deploy it for further checks ? |
jeanpommier
approved these changes
Nov 22, 2023
Not yet I'll try. At least the github actions checks passed :). |
|
Yes. and helm doesn't complain. :o) |
jeanmi151
approved these changes
Jan 24, 2024
|
Validated by deploying georchestra helm chart in test cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everywhere where it's possible, use "webapps" shortcut.
Some places might still have possible refactoring but it would need more thoughts into it.