[DB] Fix builtin DB init script. Document the DB existingSecret params #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of Builtin DBs: Init script was giving ownership of all DBs to georchestra user, no using the config params for geodata and datafeeder DBs. Which were nevertheless used by the geodata and datafeeder connection secrets. So for instance datafeeder was trying to connect with `datafeeder` user, but it had not been created. This way, the init script actually creates the users and gives them ownership on their respective DB Documentation: clarify the usage of the existingSecret params
|
@edevosc2c @jeanmi151 would you have a minute to review this one please ? |
jeanmi151
reviewed
Sep 18, 2023
It was 2 weeks ago, so I don't remember (but suppose so). Checked it right now, seems fine |
jeanmi151
approved these changes
Sep 20, 2023
edevosc2c
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
I wish there was a better way to do it like this, as .Release.Name is not a recommended value for accessing an external resource created by the parent chart.
But I'm ok with the change because for now there is no other choice that comes to my mind and this database provisioning is not targeted towards advanced setups so it will work fine on simple setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init Script:
Fix [DB] init configmap's name does not match the name in Values.yaml #48:
name of init script should match the one provided in values.yaml
In case of Builtin DBs:
Init script was giving ownership of all DBs to georchestra user, no using the config params for geodata and datafeeder DBs. Which were nevertheless used by the geodata and datafeeder connection secrets. So for instance datafeeder was trying to connect with
datafeederuser, but it had not been created.This way, the init script actually creates the users and gives them ownership on their respective DB
Documentation:
clarify the usage of the existingSecret params