Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable access logs in gateway #116

Closed
wants to merge 1 commit into from
Closed

Enable access logs in gateway #116

wants to merge 1 commit into from

Conversation

f-necas
Copy link

@f-necas f-necas commented Oct 7, 2024

Also need to have the fix in latest gateway :
georchestra/georchestra-gateway#146

@edevosc2c
Copy link
Member

Can't we do it on the application level? Or in the gateway config file?

This way anyone can turn it on or off. Here it's forced by default for everyone.

@f-necas
Copy link
Author

f-necas commented Oct 7, 2024

It can't be in gw config file but can be at application level.

For me, it should be implemented in every deployments of gw but if we don't wan't those logs we can change the level to warn to hide it.

@f-necas f-necas closed this Oct 7, 2024
@f-necas f-necas deleted the add-gw-access-logs branch October 7, 2024 13:50
@edevosc2c
Copy link
Member

Reason of closing: Was discussed in a meeting.
We shouldn't force the user to have duplicated access logs with their existing reverse proxy. Unless it's worth doing it, like if there are info that you can't find in the reverse proxy access logs (authenticated user is an example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants