add required values for database secrets #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds validation for the required values for the database secrets. That was the issue that appeared in #111, @jeanmi151 was not providing the
host
parameter when database builtin was false.If you do not provide all the database values, the helm chart will throw you an understandable message.
I have also removed the condition in which it doesn't create the georchestra database secret. Because this would allow anybody to have no secrets and not understand why the helm chart doesn't work.
Since the helm chart rely on this required georchestra database secret in order to function. All the deployments use it:
If you try to not have any secret at all, no program will work.
Related to #13