Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add required values for database secrets #113

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

edevosc2c
Copy link
Member

@edevosc2c edevosc2c commented Sep 19, 2024

This adds validation for the required values for the database secrets. That was the issue that appeared in #111, @jeanmi151 was not providing the host parameter when database builtin was false.

If you do not provide all the database values, the helm chart will throw you an understandable message.

Error: execution error at (georchestra/templates/database/database-georchestra-secret.yaml:15:11): .Values.database.auth.host is required.

Use --debug flag to render out invalid YAML

I have also removed the condition in which it doesn't create the georchestra database secret. Because this would allow anybody to have no secrets and not understand why the helm chart doesn't work.

Since the helm chart rely on this required georchestra database secret in order to function. All the deployments use it:

If you try to not have any secret at all, no program will work.

Related to #13

@edevosc2c edevosc2c merged commit 5e15c79 into main Sep 19, 2024
1 check passed
@edevosc2c edevosc2c deleted the add-required-values branch September 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants