Remove second condition about georchestra database secret

[edevosc2c]

Remove the code introduced in:

• dce999a
• 6170e5d

@jeanmi151 I tried the values.yaml in the rennes public project and I couldn't reproduce the error message in #111 (comment)

Since we can't find the real root cause, I'll assume that it was a misunderstanding about how the secrets are created by the helm chart at the time of the code was changed.

This secret creation logic has worked fine for many of Camptocamp clients (biotope, haute loire and so on) so I don't see why it wouldn't with rennes public.

[jeanmi151]

I do not approve
try with the rennes public file at the beginning !

je ne l'ai pas inventé l'erreur, ça serait pas mal de garder mes commits :)

[pmauduit]

I can reproduce by checking out the commit in the repository we are making use of this chart (on tag v1.2.0 here) just before having introduced dce999a (4th sept.), and helmfile apply leads to the following error in the output:

% helmfile template .
Adding repo georchestra https://charts.georchestra.org
"georchestra" has been added to your repositories

Adding repo bitnami-charts https://charts.bitnami.com/bitnami/
"bitnami-charts" has been added to your repositories

Building dependency release=georchestra, chart=../../../charts/georchestra
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "georchestra" chart repository
...Successfully got an update from the "charts-gs" chart repository
...Successfully got an update from the "bitnami-charts" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 2 charts
Downloading postgresql from repo oci://registry-1.docker.io/bitnamicharts
Downloading rabbitmq from repo oci://registry-1.docker.io/bitnamicharts
Deleting outdated charts

Templating release=georchestra, chart=../../../charts/georchestra
in ./helmfile.yaml: command "/home/pmauduit/bin/helm" exited with non-zero status:

PATH:
  /home/pmauduit/bin/helm

ARGS:
  0: helm (4 bytes)
  1: template (8 bytes)
  2: georchestra (11 bytes)
  3: ../../../charts/georchestra (27 bytes)
  4: --values (8 bytes)
  5: /tmp/helmfile2225424959/georchestra-values-696578dc68 (53 bytes)

ERROR:
  exit status 1

EXIT STATUS
  1

STDERR:
  Error: template: georchestra/templates/database/database-georchestra-secret.yaml:15:33: executing "georchestra/templates/database/database-georchestra-secret.yaml" at <b64enc>: invalid value; expected string
  Use --debug flag to render out invalid YAML

COMBINED OUTPUT:
  Error: template: georchestra/templates/database/database-georchestra-secret.yaml:15:33: executing "georchestra/templates/database/database-georchestra-secret.yaml" at <b64enc>: invalid value; expected string
  Use --debug flag to render out invalid YAML

Here are the versions that I am using locally:

% helm version
version.BuildInfo{Version:"v3.15.4", GitCommit:"fa9efb07d9d8debbb4306d72af76a383895aa8c4", GitTreeState:"clean", GoVersion:"go1.22.6"}

% helmfile version

▓▓▓ helmfile

  Version            1.0.0-rc.4
  Git Commit         86664f5
  Build Date         04 Aug 24 04:30 CEST (1 month ago)
  Commit Date        03 Aug 24 01:53 CEST (1 month ago)
  Dirty Build        no
  Go version         1.22.4
  Compiler           gc
  Platform           linux/amd64