Introducing a filter parameter on the "items" endpoint #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmauduit
commented
Sep 5, 2023
Comment on lines
+111
to
+119
| You can also use the "f" parameter to pass the requested format to the request for convenience ; below | ||
| is the list of possible values: | ||
|
|
||
| * json | ||
| * geojson | ||
| * shapefile | ||
| * csv | ||
| * ooxml | ||
|
|
There was a problem hiding this comment.
unrelated, but was discussed during the weekly on 4th sept.
pmauduit
commented
Sep 5, 2023
Comment on lines
53
to
57
| @Test | ||
| public void testGetItemsWithFilter() { | ||
| MockHttpServletRequest actualRequest = (MockHttpServletRequest) req.getNativeRequest(); | ||
| actualRequest.addHeader("Accept", "application/json"); | ||
| ResponseEntity<FeatureCollection> response = collectionsApi.getFeatures("locations", -1, | ||
| null, null, "number = 140"); | ||
|
|
||
| assertThat(response.getBody().getFeatures().toList().size()) | ||
| .isEqualTo(1); | ||
| } |
There was a problem hiding this comment.
this test fails on the "sample-data" spring profile but works fine when using the "postgis" one.
pmauduit
commented
Sep 5, 2023
pmauduit
force-pushed
the
cql-filtering-on-items
branch
2 times, most recently
from
efd708f
to
5029681
Compare
…profile Also adding a application.yml on the test classpath to make test config easier.
pmauduit
force-pushed
the
cql-filtering-on-items
branch
from
5029681
to
c5d3225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.