Fix OGC API shapefile download #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shapefile download links resulted in a 500 http error code. Reason being the GeoTools Shapefile DataStore will always set the default geometry attribute as the first one in the FeatureTypes it creates, hence simple writing of original feature to target feature failed.
pmauduit
approved these changes
Jun 24, 2024
From my understanding, the ideal behaviour would have been to respect the order & definition of the original feature store, but if this a limitation of geotools and/or shapefile format, I think we can live with it. |
|
it is a limitation of shapefile because geometry and attributes are in different files, and there's no sidecar file to specify the order of the attributes, nor the alias, so attribute names are truncated to 8 chars |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shapefile download links resulted in a 500 http error code. Reason being the GeoTools Shapefile DataStore will always set the default geometry attribute as the first one in the FeatureTypes it creates, hence simple writing of original feature to target feature failed.