-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker extension #46
base: master
Are you sure you want to change the base?
Docker extension #46
Conversation
I have tested and tried to understand as maximum as I could, as far as could understand and IMHO. I have some comments concerning this PR
My recommendations:
My IMHO:
@lazaa32 Care to comment in case I am missing something or not having a clear idea of what is going on |
I agree with you. I made both PRs to let you know that work both on pywps-flask and pywps is ready to test. Once geopython/pywps#443 is merged into master, there is no need for any other branch.
Could you check whether a container is at least created and started after submitting a request, please?
+1
It would be nice to get this merged by mid January. Right now I have a good wifi connection but later I can't promise I will have a chance to work on this constantly due to lack of electric power and wifi :(. |
During my initial tests the docker containers where created. I will make a more extensive check to determine why they are not connecting |
Overview
Docker extension for pywps-flask.
Updated readme.
Added parameters to config file.
Added requests for tests.
Updated isolation Dockerfile.
Related Issue / Discussion
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)