Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve snapping demo behavior #277

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

oterral
Copy link
Contributor

@oterral oterral commented Sep 24, 2024

How to

To make the snapping experience better we decide to remove the snapping button in the demo .

This PR also fix bugs:

  • impossible when drawing a line/polygon to snap on the other points.
  • duplicate vetticla lines were badly detected due to too much recise conversion between pixel and coordinates
  • update eslint 9

This happens because the modified node was not exclude from snappable points list, the code incriminated was the getShiftedMultipoint method

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title is formatted as a conventional-commit message.
  • The title contains WIP: if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

IMPORTANT: Squash commits before or on merge to prevent every small commit being written into the change log. The Pull Request title will be written as message for the new commit containing the squashed commits and there fore needs to be in conventional-commit format

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openlayers-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 7:45am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant