Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit #2

Merged
merged 31 commits into from
Dec 19, 2022
Merged

Initial commit #2

merged 31 commits into from
Dec 19, 2022

Conversation

alasarr
Copy link
Collaborator

@alasarr alasarr commented Dec 18, 2022

On this PR, I've moved the scripts from: opengeospatial/geoparquet#113

I've also added several improvements:

  • Remove poetry, I really like poetry as a developer but I think could be an issue for adoption as not all users use poetry.
  • Allow overwriting files.
  • Update some dependencies.
  • CI for testing.
  • CI job to upload several tables to gs://geoparquet. I've added US boundaries.

The following files have been created from bigquery and uploaded to geoparquet bucket:

https://storage.googleapis.com/geoparquet/geography_usa_state_2019.parquet
https://storage.googleapis.com/geoparquet/geography_usa_county_2019.parquet
https://storage.googleapis.com/geoparquet/geography_usa_censustract_2019.parquet
https://storage.googleapis.com/geoparquet/geography_usa_zcta5_2019.parquet
https://storage.googleapis.com/geoparquet/geography_usa_blockgroup_2019.parquet

@alasarr alasarr requested review from tschaub and cholmes December 18, 2022 12:20
Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not a python dev so only am commenting on the readme - put in a minor language edit.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Holmes <[email protected]>
@alasarr alasarr merged commit 59f78ab into main Dec 19, 2022
@cholmes cholmes deleted the alasarr/initial-commit branch December 19, 2022 19:09
@kylebarron
Copy link

  • Remove poetry, I really like poetry as a developer but I think could be an issue for adoption as not all users use poetry

It's fine if you don't use poetry here, but just as a general comment, poetry supports PEP 517, so you don't need poetry installed to install a package that uses poetry. pip install . will just work.

1 similar comment
@kylebarron
Copy link

  • Remove poetry, I really like poetry as a developer but I think could be an issue for adoption as not all users use poetry

It's fine if you don't use poetry here, but just as a general comment, poetry supports PEP 517, so you don't need poetry installed to install a package that uses poetry. pip install . will just work.

@alasarr
Copy link
Collaborator Author

alasarr commented Dec 27, 2022

It's fine if you don't use poetry here, but just as a general comment, poetry supports PEP 517, so you don't need poetry installed to install a package that uses poetry. pip install . will just work.

No idea about it @kylebarron, thanks for letting me know. I'll add poetry then, if you want to commit that would be great too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants