Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME: revert image input component #959

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

LHBruneton-C2C
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C commented Aug 9, 2024

Description

This PR introduces reverts a few changes done in #909 that were breaking the Storybook build.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Affected libs: feature-editor, ui-inputs, feature-dataviz, feature-record, feature-router, feature-search, feature-map, ui-elements, feature-notifications, feature-catalog, ui-catalog, ui-search, ui-layout,
Affected apps: metadata-editor, datafeeder, demo, metadata-converter, datahub, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Aug 9, 2024

📷 Screenshots are here!

@Input() maxSizeMB: number
@Input() previewUrl?: URL
@Input() previewUrl?: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only really necessary change; the type should be switched back to string, and the overview-upload component should be adapted accordingly

@jahow jahow marked this pull request as ready for review August 13, 2024 08:00
@coveralls
Copy link

coveralls commented Aug 13, 2024

Coverage Status

coverage: 81.158% (-2.4%) from 83.543%
when pulling e92f231 on ME/fix-graphic-overview
into ac57b75 on main.

@jahow jahow force-pushed the ME/fix-graphic-overview branch 2 times, most recently from a7b0bde to a3ec78c Compare August 14, 2024 08:19
@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/fix-graphic-overview branch from a3ec78c to 38c414a Compare August 19, 2024 15:05
@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/fix-graphic-overview branch from 38c414a to e92f231 Compare August 20, 2024 07:30
@LHBruneton-C2C LHBruneton-C2C merged commit c5f4c49 into main Aug 20, 2024
11 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the ME/fix-graphic-overview branch August 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants