Another attempt at making E2E tests more reliable #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The record soes not require a login anymore, and no http interception either
The "record with no link" record is now public
|
Affected libs:
|
|
📷 Screenshots are here! |
jahow
force-pushed
the
fix-e2e-test-flaky
branch
from
1fef47b to
e898909
Compare
Angi-Kinas
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Thanks @jahow for making the e2e test more reliable!
The PR looks good to me, I was just wondering about this one file if it is meant to be here.
| @@ -18,3 +18,12 @@ do | |||
| echo "" | |||
There was a problem hiding this comment.
Is this change supposed to be part of the PR? Not sure if it is necessary for the test or it came in by mistake.
There was a problem hiding this comment.
yes definitely, I added some more logging because I've noticed that sometimes the thesauri are not correctly present when running the e2e tests, and that would cause one of the very common failures. Having more logging will help investigating if these failures show up again.
|
🤞 🤞 thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Architectural changes
Updated the DB dump to make the "record with no link" public.
Quality Assurance Checklist
breaking changelabelbackport <release branch>label