Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDITOR - Record field: Contacts for resource #951

Merged
merged 5 commits into from
Aug 21, 2024
Merged

EDITOR - Record field: Contacts for resource #951

merged 5 commits into from
Aug 21, 2024

Conversation

rcaplier
Copy link
Collaborator

Description

This PR introduces the contacts for resources field.

image

[...]

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

**This work is sponsored by **.

@rcaplier rcaplier self-assigned this Jul 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 29, 2024 •
edited
Loading

Affected libs: common-domain, api-metadata-converter, api-repository, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, feature-auth, ui-search, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: metadata-editor, metadata-converter, datahub, demo, webcomponents, map-viewer, search, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 29, 2024 •
edited
Loading

📷 Screenshots are here!

@rcaplier rcaplier force-pushed the me-record-field-contacts-for-resource branch 3 times, most recently from 8f341a1 to 4c0a267 Compare July 31, 2024 11:59
@rcaplier rcaplier marked this pull request as ready for review July 31, 2024 12:01
@rcaplier rcaplier force-pushed the me-record-field-contacts-for-resource branch 8 times, most recently from 53df31a to 6bb874a Compare August 1, 2024 07:41
Angi-Kinas
Angi-Kinas reviewed Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcaplier thank you for this feature! I haven't tested anything yet, just had a look at the code. It's really readable, thanks for that!
I have some suggestions, most of them minor things :)

translations/en.json Outdated Show resolved Hide resolved
libs/feature/editor/src/lib/fields.config.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
libs/feature/editor/src/lib/components/contact-card/contact-card.component.html Outdated Show resolved Hide resolved
jahow
jahow reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work! I think the form-field-contacts component can still be improved and simplified.

I had various errors when trying to add the "admin admin" contact, such as:
image

I think this is because this contact has no organization, but I'm not sure exactly where the error comes from.

libs/common/domain/src/lib/model/record/contact.model.ts Outdated Show resolved Hide resolved
libs/common/domain/src/lib/model/record/contact.model.ts Outdated Show resolved Hide resolved
libs/feature/editor/src/lib/components/contact-card/contact-card.component.html Outdated Show resolved Hide resolved
libs/feature/editor/src/lib/components/contact-card/contact-card.component.html Outdated Show resolved Hide resolved
libs/feature/editor/src/lib/components/contact-card/contact-card.component.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
@rcaplier rcaplier force-pushed the me-record-field-contacts-for-resource branch 2 times, most recently from d8a24d3 to 60edb09 Compare August 20, 2024 09:10
jahow
jahow reviewed Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remaining comments on my side, I'll let @Angi-Kinas give the final review since she was the one looking in to this first :) thanks!

...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
...rm/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts Outdated Show resolved Hide resolved
@rcaplier rcaplier force-pushed the me-record-field-contacts-for-resource branch 5 times, most recently from d5679f1 to 0a26381 Compare August 21, 2024 13:30
@rcaplier rcaplier force-pushed the me-record-field-contacts-for-resource branch from 0a26381 to d81a547 Compare August 21, 2024 13:31
@coveralls
Copy link

Coverage Status

coverage: 82.96% (-0.6%) from 83.55%
when pulling d81a547 on me-record-field-contacts-for-resource
into d5b28b1 on main.

jahow
jahow approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! thanks!

@rcaplier rcaplier merged commit 2cc6f5b into main Aug 21, 2024
11 checks passed
@rcaplier rcaplier deleted the me-record-field-contacts-for-resource branch August 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angi-Kinas Angi-Kinas Angi-Kinas left review comments

@jahow jahow jahow approved these changes

Assignees

@rcaplier rcaplier

Labels
major feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rcaplier @coveralls @jahow @Angi-Kinas