Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Make geo data badge more readable #946

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Datahub: Make geo data badge more readable #946

merged 3 commits into from
Jul 30, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Jul 22, 2024

Description

PR removes the background color from geo data badge to make it more readable in a generic way.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by geo2france.

to make it more readable in a generic way
Copy link
Contributor

github-actions bot commented Jul 22, 2024

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Jul 22, 2024

📷 Screenshots are here!

@jahow
Copy link
Collaborator

jahow commented Jul 22, 2024

This PR removes the background, right? Can't we simply use a normal badge, and not simply use the foreground color in that case?

@tkohr
Copy link
Collaborator Author

tkohr commented Jul 22, 2024

This PR removes the background, right? Can't we simply use a normal badge, and not simply use the foreground color in that case?

Indeed, it would be an alternative to use the same badge style as under the search input (with badge-btn bg-primary-opacity-50 and some more modifications). Personally, I had a slight preference to the outcome with a style consistent to the update date (same foreground color and no badge layout anymore), but if we really want to keep a badge layout this is an option.

@tkohr
Copy link
Collaborator Author

tkohr commented Jul 24, 2024

A second look using light text and opacity 1 for the background via the gn-ui-badge convinced me of its outcome :

image

I made the opacity configurable along the way. Hope this is what you had in mind @jahow.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!! The margins look a bit off compared to the mockup:
image

I'll let you judge, merge when you want!

@tkohr
Copy link
Collaborator Author

tkohr commented Jul 24, 2024

Hum, the figma mockup is a little different I have the impression

@tkohr tkohr merged commit 83f4887 into main Jul 30, 2024
9 checks passed
@tkohr tkohr deleted the geo-badge branch July 30, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants