-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datahub: Make geo data badge more readable #946
Conversation
to make it more readable in a generic way
Affected libs: ``,
|
📷 Screenshots are here! |
This PR removes the background, right? Can't we simply use a normal badge, and not simply use the foreground color in that case? |
Indeed, it would be an alternative to use the same badge style as under the search input (with |
A second look using light text and opacity 1 for the background via the I made the opacity configurable along the way. Hope this is what you had in mind @jahow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, the figma mockup is a little different I have the impression |
Description
PR removes the background color from geo data badge to make it more readable in a generic way.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by geo2france.