-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata Editor / fix error when saving with GeoNetwork 4.2.5+ #945
Conversation
Affected libs:
|
📷 Screenshots are here! |
69abd8a
to
99485f7
Compare
This PR most likely fixes #935 |
dcc9b80
to
a7f6a69
Compare
a56fe6f
to
2541c6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
I'm not very quite used with the githubwork workflow stuff so I trust you on that.
Also regenerates API client This fixes an error when trying to save a record with GN 4.2.5+
2eeff24
to
a30b458
Compare
minor improvements to init service to improve readability
a30b458
to
fc98081
Compare
The E2E tests are still flaky, I'll try to improve them |
576ee77
to
ab02d71
Compare
ab02d71
to
583c63f
Compare
Description
This PR fixes an issue where saving would fail with a 500 HTTP error with GeoNetwork versions of 4.2.5 and above.
This is because:
insert
API only accept the XMLContent-Type: application/json
header, which failed because this content type was not handled anymore in GeoNetwork APIRemaining to do:
Architectural changes
GN4 API client was regenerated
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label