Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub] Fix read more button #934

Merged
merged 2 commits into from
Jul 4, 2024
Merged

[Datahub] Fix read more button #934

merged 2 commits into from
Jul 4, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Jul 4, 2024

Description

PR fixes the read more button for the description, which has become a standalone component.

Bug does not seem to be present on 2.3.x branch.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Affected libs: ui-elements, feature-notifications, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-editor, ui-catalog, ui-search, ui-layout,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 83.973% (+0.9%) from 83.112%
when pulling 51881b1 on fix-max-lines
into fe59f17 on main.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

📷 Screenshots are here!

Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well, thank you for noticing this ! 😃

@tkohr tkohr merged commit 9121e5f into main Jul 4, 2024
9 checks passed
@tkohr tkohr deleted the fix-max-lines branch July 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants