ME: Adapt styling of sidebar #927
Conversation
|
Affected libs:
|
|
📷 Screenshots are here! |
| <ng-container *ngrxLet="platformService.getMe() as user"> | ||
| <div | ||
| *ngIf="user && user.name" |
There was a problem hiding this comment.
I don't really get the need for ngrxLet if you're still using ngIf afterwards, but I'm discovering this ngrxLet feature as I do this review, so this is more about cuiosity ^
There was a problem hiding this comment.
I think I copied this over from search-header.component.html. I changed it to use 'ngIf' now, because we know it better.
| class="w-10 h-10 flex justify-center items-center hover:cursor-pointer" | ||
| > | ||
| <gn-ui-user-preview | ||
| *ngIf="user && user.name" |
There was a problem hiding this comment.
This has already been checked 2 levels up.
org name and org logo, user logo and shut icon, fix and add translations
Angi-Kinas
force-pushed
the
ME-adapt-display-sidebar
branch
from
0f496e5 to
60f463f
Compare
|
@LHBruneton-C2C thank you for the review! It's strange though that you don't see the logo of the editor even though you don't have a 404 in the network. @rcaplier could you also have a look at this branch and see if the logo on the top left displays or not? Then I could investigate further. |
|
Just checked quickly and the logo shows up on my side: |
This PR introduces additional styling according to the given Mockups.
Note:
The log out icon and the user icon are not accessible via keyboard, even though they are wrapped in a
<gn-ui-button>. This needs to be fixed.Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>label