Datasets figure web component #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
|
📷 Screenshots are here! |
rcaplier
reviewed
Jun 26, 2024
| constructor(injector: Injector, private changeDetector: ChangeDetectorRef) { | ||
| super(injector) | ||
| this.catalogRecords = injector.get(RecordsService) | ||
| this.recordsCount$ = this.catalogRecords.recordsCount$.pipe(startWith('-')) |
There was a problem hiding this comment.
I would add a catchError(()=> of('-')) to stay consistent with the way you built it.
I like the way that you start with an '-'.
Since you put : catchError(() => of(0)) on the recordsCount$ in the service, in case of error it will display to the user 0 wich is wrong (could be 14 or 392).
What do you think about this ?
rcaplier
approved these changes
Jun 26, 2024
Angi-Kinas
approved these changes
Jun 26, 2024
jahow
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new web component to display the amount of datasets within your catalog.
It's based on the
<gn-figure>Angular componentScreenshots
Quality Assurance Checklist
This work is sponsored by Florent Gravin Enterprise.